Skip to content

disable inconsistentCjsInterop again#6046

Merged
adhami3310 merged 1 commit intomainfrom
disable-inconsistentCjsInterop-again
Dec 15, 2025
Merged

disable inconsistentCjsInterop again#6046
adhami3310 merged 1 commit intomainfrom
disable-inconsistentCjsInterop-again

Conversation

@adhami3310
Copy link
Copy Markdown
Member

:/ it causes issues because it's different in dev from prod

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Dec 15, 2025

CodSpeed Performance Report

Merging #6046 will not alter performance

Comparing disable-inconsistentCjsInterop-again (74a0c26) with main (2907722)

Summary

✅ 8 untouched

@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Dec 15, 2025

Greptile Overview

Greptile Summary

Reverts the legacy.inconsistentCjsInterop Vite configuration that was added in PR #6044. This setting was causing issues due to different behavior between development and production builds.

  • Removes the legacy: { inconsistentCjsInterop: true } block from the Vite config template
  • This is a simple revert of a recently added configuration option that proved problematic

Confidence Score: 5/5

  • This PR is safe to merge - it's a straightforward revert of a problematic configuration option.
  • Score reflects: (1) minimal code change removing only 3 lines, (2) reversion of a recently added config that caused issues, (3) no logic changes, (4) author is the same person who added the original change and understands the issue.
  • No files require special attention.

Important Files Changed

File Analysis

Filename Score Overview
reflex/compiler/templates.py 5/5 Removed legacy: { inconsistentCjsInterop: true } from Vite config to fix dev/prod inconsistency issues.

Sequence Diagram

sequenceDiagram
    participant Dev as Development Build
    participant Prod as Production Build
    participant Vite as Vite Config
    
    Note over Vite: Before (with inconsistentCjsInterop: true)
    Dev->>Vite: Build with legacy CJS interop
    Prod->>Vite: Build with legacy CJS interop
    Note over Dev,Prod: Behaves differently in dev vs prod
    
    Note over Vite: After (option removed)
    Dev->>Vite: Build with default ESM behavior
    Prod->>Vite: Build with default ESM behavior
    Note over Dev,Prod: Consistent behavior
Loading

Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, no comments

Edit Code Review Agent Settings | Greptile

@adhami3310 adhami3310 merged commit bd1f7c6 into main Dec 15, 2025
47 checks passed
@adhami3310 adhami3310 deleted the disable-inconsistentCjsInterop-again branch December 15, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants